Parse NC_RTXPRO6000BSE_v6 GPU VM sizes#34
Merged
MaximilianoUribe merged 1 commit intoJun 15, 2026
Merged
Conversation
The NC RTX PRO 6000 BSE v6 GPU sizes use a new naming shape that the size parser could not match, e.g. NC288ds_xl_RTXPRO6000BSE_v6, causing 'could not parse VM size' errors. Two elements were unsupported: - the 'xl_' size descriptor that precedes the accelerator, and - an accelerator name with trailing letters (RTXPRO6000BSE), while the accelerator group only matched <letters><digits>. Extend the accelerator group to '(xl_[A-Z]+[0-9]+[A-Z]*|[A-Z]+[0-9]+)'. The trailing-letters form is gated behind the literal 'xl_' so existing accelerators (e.g. MI300X, H100) keep hitting their dedicated groups and their series flags are unchanged. The 'xl_' descriptor is stripped so AcceleratorType reflects the accelerator name only (RTXPRO6000BSE). Applied to both the root and v2 modules, with tests for the ds and lds variants. The full real-SKU corpus (TestParseVMSize) still passes with no regressions.
matthchr
approved these changes
Jun 15, 2026
matthchr
left a comment
Member
There was a problem hiding this comment.
LGTM but let's maybe get @jackfrancis to take a look too?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Parse the NC RTX PRO 6000 BSE v6 GPU VM sizes, e.g.
Standard_NC288ds_xl_RTXPRO6000BSE_v6.Today these fail with
could not parse VM size ...because the size scheme does not handle two new elements in the name:xl_size descriptor that precedes the accelerator, andRTXPRO6000BSE), while the accelerator group only matched<letters><digits>([A-Z]+[0-9]+).These sizes are public and documented: https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nc-rtxpro6000-bse-v6-series
Change
Extend the accelerator capture group:
xl_so existing accelerators (MI300X,H100,A100,T4, …) keep matching their original/dedicated groups and their series flags (MI300Series,H100Series) are unchanged. (An ungated[A-Z]*would have swallowedMI300Xinto the accelerator group and flippedMI300Series.)xl_descriptor is stripped soAcceleratorTypereflects the accelerator name only (RTXPRO6000BSE).Applied to both the root module and
v2/.Tests
Test_GetVMSizecases for thedsandldsvariants (NC288ds_xl_RTXPRO6000BSE_v6,NC24lds_xl_RTXPRO6000BSE_v6).TestParseVMSizeover the generated real-SKU corpus passes with 0 failures (no regressions), in both modules.gofmt,go test ./...green for root andv2.Note
The
xltoken is not yet listed in the VM sizes naming conventions doc; the series page above is the current public reference.